PDPDEVTOOL-6272: Create UI to provide Feedback Loop for DevAssist #971
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
…op-UI # Conflicts: # packages/vscode-extension/messages.json # packages/vscode-extension/src/service/TranslationKeys.ts
packages/vscode-extension/src/startup/DevAssistConfiguration.ts
Outdated
Show resolved
Hide resolved
| ] | ||
|
|
||
| let feedbackFormPanel: vscode.WebviewPanel | undefined; | ||
| let vscodeExtensionMediaPath : string; |
There was a problem hiding this comment.
I would like to have a service that can get the html content instead of constructing the path each time. It will make the implementation cleaner.
There was a problem hiding this comment.
Implemented a MediaFileService (naming could be improved).
It mostly does what we discussed, the only limitation being that CSS file paths must be relative to the VSCode.WebView. Therefore, the cssUri must be calculated on the WebViewController and passed to the MediaFileService.
|
|
||
| // Handle messages/events sent from the webview | ||
| feedbackFormPanel.webview.onDidReceiveMessage( | ||
| (webviewMessage) => handleWebviewMessage(webviewMessage, feedbackFormCSSFilePath), |
There was a problem hiding this comment.
I think I would prefer webviewEvent instead of webviewMessage
| return true; | ||
| } | ||
|
|
||
| const handleWebviewMessage = async (webviewMessage : any, feedbackFormCSSFilePath : string) : Promise<void> => { |
There was a problem hiding this comment.
Lets try to shape the webviewMessage/webviewEvent with a proper type.
| } catch (error) { | ||
| // VSCODE ERROR, PROXY_NOT_LOADED, PROXY_ERROR, REQUEST_FORMATING_ERROR (Not even a response received) | ||
| vsLogger.printTimestamp(); | ||
| vsLogger.error(translationService.getMessage(DEVASSIST_SERVICE.FEEDBACK_FORM.SUBMITTING_ERROR_TOAST, error ? '\n' + error : '')); |
There was a problem hiding this comment.
Should this be the internal error?
There was a problem hiding this comment.
Guess I copied/pasted too quickly.
Solved
3 participants
On Code Review:
Missing from the code review